New option to scan; Snipping Tool #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just commenting in case it seems in ignoring this or but I actually have exams right now so I will check this PR in a few weeks. This or looks really promising adding some truly great feature so I thank you for that. |
|
This PR looks good I will be merging it and adding it in 2.0 |
|
Great! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7
Description
If you click 'Scan QR > From Screen', the window goes to
CompactOverlayview mode, and the snipping tool will be opened. After scanning the QR,AddAccountPagewill be opened, and textboxes will be filled up.Change
MainPage.xaml.TOTPUriHelper.csto parse TOTP URI.TOTPClass.cs.OnNavigatedTomethod ofAddAccountPage.xaml.csto use the parameter asTOTPClass.