Apply

crypto/keyring/keyring.go

@@ -691,7 +691,7 @@ func newFileBackendKeyringConfig(name, dir string, buf io.Reader) keyring.Config
 
 func newRealPrompt(dir string, buf io.Reader) func(string) (string, error) {
 	return func(prompt string) (string, error) {
-		keyhashStored := false
+		var keyhashStored bool
 		keyhashFilePath := filepath.Join(dir, "keyhash")
 
 		var keyhash []byte

types/decimal.go

@@ -744,7 +744,7 @@ func (d *Dec) MarshalTo(data []byte) (n int, err error) {
 // Unmarshal implements the gogo proto custom type interface.
 func (d *Dec) Unmarshal(data []byte) error {
 	if len(data) == 0 {
-		d = nil
+		d = nil //nolint: wastedassign
 		return nil
 	}
 

types/int.go

@@ -403,7 +403,7 @@ func (i *Int) MarshalTo(data []byte) (n int, err error) {
 // Unmarshal implements the gogo proto custom type interface.
 func (i *Int) Unmarshal(data []byte) error {
 	if len(data) == 0 {
-		i = nil
+		i = nil //nolint: wastedassign
 		return nil
 	}
 

types/uint.go

@@ -178,7 +178,7 @@ func (u *Uint) MarshalTo(data []byte) (n int, err error) {
 // Unmarshal implements the gogo proto custom type interface.
 func (u *Uint) Unmarshal(data []byte) error {
 	if len(data) == 0 {
-		u = nil
+		u = nil //nolint: wastedassign
 		return nil
 	}
 

x/auth/ante/sigverify.go

@@ -308,11 +308,11 @@ func (svd *SigVerificationDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simu
 		if !simulate {
 			if !genesis {
 				sigKey := fmt.Sprintf("%d:%d", signerData.AccountNumber, signerData.Sequence)
-				// TODO could we use `tx.(*wrapper).getBodyBytes()` instead of `ctx.TxBytes()`?
+				// TODO: could we use `tx.(*wrapper).getBodyBytes()` instead of `ctx.TxBytes()`?
 				txHash := sha256.Sum256(ctx.TxBytes())
-				stored := false
+				var stored bool
 
-				// TODO(duong2): Does this really improve performance?
+				// TODO: Does this really improve performance?
 				stored, err = svd.verifySignatureWithCache(ctx, pubKey, signerData, sig.Data, tx, sigKey, txHash[:])
 
 				if stored {

x/auth/client/testutil/suite.go

@@ -1268,7 +1268,7 @@ func (s *IntegrationTestSuite) TestQueryModuleAccountByNameCmd() {
 
 func TestGetBroadcastCommandOfflineFlag(t *testing.T) {
 	clientCtx := client.Context{}.WithOffline(true)
-	clientCtx = clientCtx.WithTxConfig(simapp.MakeTestEncodingConfig().TxConfig) //nolint:staticcheck
+	_ = clientCtx.WithTxConfig(simapp.MakeTestEncodingConfig().TxConfig)
 
 	cmd := authcli.GetBroadcastCommand()
 	_ = testutil.ApplyMockIODiscardOutErr(cmd)

x/auth/client/tx_test.go

@@ -39,7 +39,7 @@ func TestParseQueryResponse(t *testing.T) {
 	require.Equal(t, 10, int(res.GasInfo.GasUsed))
 	require.NotNil(t, res.Result)
 
-	res, err = authclient.ParseQueryResponse([]byte("fuzzy"))
+	_, err = authclient.ParseQueryResponse([]byte("fuzzy"))
 	require.Error(t, err)
 }
 

x/gov/genesis_test.go

@@ -104,7 +104,7 @@ func TestImportExportQueues(t *testing.T) {
 	// Run the endblocker. Check to make sure that proposal1 is removed from state, and proposal2 is finished VotingPeriod.
 	gov.EndBlocker(ctx2, app2.GovKeeper)
 
-	proposal1, ok = app2.GovKeeper.GetProposal(ctx2, proposalID1)
+	_, ok = app2.GovKeeper.GetProposal(ctx2, proposalID1)
 	require.False(t, ok)
 
 	proposal2, ok = app2.GovKeeper.GetProposal(ctx2, proposalID2)

x/gov/keeper/deposit_test.go

@@ -96,7 +96,7 @@ func TestDeposits(t *testing.T) {
 	require.True(t, found)
 	require.Equal(t, fourStake, deposit.Amount)
 	app.GovKeeper.RefundDeposits(ctx, proposalID)
-	deposit, found = app.GovKeeper.GetDeposit(ctx, proposalID, TestAddrs[1])
+	_, found = app.GovKeeper.GetDeposit(ctx, proposalID, TestAddrs[1])
 	require.False(t, found)
 	require.Equal(t, addr0Initial, app.BankKeeper.GetAllBalances(ctx, TestAddrs[0]))
 	require.Equal(t, addr1Initial, app.BankKeeper.GetAllBalances(ctx, TestAddrs[1]))

x/staking/handler_test.go

@@ -893,7 +893,7 @@ func TestMultipleRedelegationAtSameTime(t *testing.T) {
 
 	// move forward in time, should complete both redelegations
 	ctx = tstaking.TurnBlockTimeDiff(1 * time.Second)
-	rd, found = app.StakingKeeper.GetRedelegation(ctx, selfDelAddr, valAddr, valAddr2)
+	_, found = app.StakingKeeper.GetRedelegation(ctx, selfDelAddr, valAddr, valAddr2)
 	require.False(t, found)
 }
 
@@ -940,7 +940,7 @@ func TestMultipleRedelegationAtUniqueTimes(t *testing.T) {
 
 	// move forward in time, should complete the second redelegation
 	ctx = tstaking.TurnBlockTimeDiff(5 * time.Second)
-	rd, found = app.StakingKeeper.GetRedelegation(ctx, selfDelAddr, valAddr, valAddr2)
+	_, found = app.StakingKeeper.GetRedelegation(ctx, selfDelAddr, valAddr, valAddr2)
 	require.False(t, found)
 }
 
@@ -980,7 +980,7 @@ func TestMultipleUnbondingDelegationAtSameTime(t *testing.T) {
 
 	// move forwaubd in time, should complete both ubds
 	ctx = tstaking.TurnBlockTimeDiff(1 * time.Second)
-	ubd, found = app.StakingKeeper.GetUnbondingDelegation(ctx, selfDelAddr, valAddr)
+	_, found = app.StakingKeeper.GetUnbondingDelegation(ctx, selfDelAddr, valAddr)
 	require.False(t, found)
 }
 
@@ -1028,7 +1028,7 @@ func TestMultipleUnbondingDelegationAtUniqueTimes(t *testing.T) {
 
 	// move forwaubd in time, should complete the second redelegation
 	ctx = tstaking.TurnBlockTimeDiff(5 * time.Second)
-	ubd, found = app.StakingKeeper.GetUnbondingDelegation(ctx, selfDelAddr, valAddr)
+	_, found = app.StakingKeeper.GetUnbondingDelegation(ctx, selfDelAddr, valAddr)
 	require.False(t, found)
 }
 

x/staking/keeper/delegation_test.go

@@ -350,7 +350,7 @@ func TestUndelegateSelfDelegationBelowMinSelfDelegation(t *testing.T) {
 	require.NoError(t, simapp.FundModuleAccount(app, ctx, bondedPool.GetName(), delCoins))
 	app.AccountKeeper.SetModuleAccount(ctx, bondedPool)
 
-	validator = keeper.TestingUpdateValidator(app.StakingKeeper, ctx, validator, true)
+	_ = keeper.TestingUpdateValidator(app.StakingKeeper, ctx, validator, true)
 	delegation := types.NewDelegation(addrDels[0], addrVals[0], issuedShares)
 	app.StakingKeeper.SetDelegation(ctx, delegation)