Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement MockApi::new_with_gas_cost #89

Merged
merged 1 commit into from
Mar 25, 2021
Merged

feat: Implement MockApi::new_with_gas_cost #89

merged 1 commit into from
Mar 25, 2021

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Mar 23, 2021

Implement MockApi::new_with_gas_cost(canonicalize_cost, humanize_cost) and tests of them.

Closes: #88

Description

Implement MockApi::new_with_gas_cost(canonicalize_cost, humanize_cost) and tests of them.
This is for measuring how much gas is costed in integration tests with specified gas cost.

Motivation and context

see #88 for detail.

How has this been tested?

unit tests in vm::testing::mocks.rs

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@loloicci loloicci added the VM label Mar 23, 2021
@loloicci loloicci self-assigned this Mar 23, 2021
@loloicci loloicci changed the title impl: Implement MockApi::new_with_gas_cost feat: Implement MockApi::new_with_gas_cost Mar 23, 2021
Implement MockApi::new_with_gas_cost(canonicalize_cost, humanize_cost)
and tests of them.

This is for measuring how much gas is costed in integration tests
with specified gas cost.
Copy link
Contributor

@whylee259 whylee259 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@brew0722 brew0722 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 49f5aad into Finschia:develop Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MockApi::new_with_gas_costs(humanize_cost, canonicalize_cost)
4 participants