Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix keys of action caches for contracts #204

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Jun 3, 2022

Description

Now, the key of action caches for contracts uses cacheFiles('Cargo.lock'). The Cargo.toml excludes contracts/*, so this key does not work well. This PR fix this to use contracts/[contract-name]/Cargo.lock.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci requested review from zemyblue and shiki-tak June 3, 2022 04:57
@loloicci loloicci self-assigned this Jun 3, 2022
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue
Copy link
Member

zemyblue commented Jun 3, 2022

@loloicci , The CI failure is fixed if applying the changes of #203 ?

@loloicci
Copy link
Contributor Author

loloicci commented Jun 3, 2022

The CI failure is fixed if applying the changes of #203 ?

Yes, it is fixed in #203.

@loloicci loloicci merged commit 5fcec00 into Finschia:main Jun 3, 2022
@loloicci loloicci deleted the fix-action-cache-contracts branch June 3, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants