Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration tests for query-queue #197

Merged
merged 5 commits into from
Jun 1, 2022
Merged

feat: add integration tests for query-queue #197

merged 5 commits into from
Jun 1, 2022

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented May 24, 2022 •
edited
Loading

Description

  • Add a very simple integration test for query-queue
  • Add an integration test using countract "queue"
  • Add ci tests for query-queue

Closes #194

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this May 24, 2022
@loloicci loloicci marked this pull request as ready for review May 24, 2022 12:40
@loloicci loloicci changed the title feat: add tests for query-queue feat: add integration tests for query-queue May 27, 2022
shiki-tak
shiki-tak approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@shiki-tak shiki-tak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zemyblue
zemyblue approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loloicci loloicci merged commit 1cb5981 into Finschia:main Jun 1, 2022
@loloicci loloicci deleted the add-test-query-queue branch June 1, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiki-tak shiki-tak shiki-tak approved these changes

@zemyblue zemyblue zemyblue approved these changes

@brew0722 brew0722 Awaiting requested review from brew0722

Assignees

@loloicci loloicci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query-queue contract doesn't have integration test.
3 participants
@loloicci @zemyblue @shiki-tak