Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merge 0.14.0 #122

Merged
merged 232 commits into from
Jun 22, 2021
Merged

feat: merge 0.14.0 #122

merged 232 commits into from
Jun 22, 2021

Conversation

shiki-tak
Copy link
Contributor

Closes: #121

Description

Motivation and context

How has this been tested?

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

maurolacy and others added 30 commits March 13, 2021 18:49
@maurolacy
Add synchronized access to get_instance
5eebf03
@maurolacy
Implement guarded InnerCache
0528404
@maurolacy
Avoid potential deadlocks in get_instance / pin
db1d77c
@maurolacy
Mark Cache as Sync
6332ec3
@webmaster128
Implement Display for Checksum
5cb04b5
@webmaster128
Use interior mutability
78c659d
@webmaster128
Implement Send for Cache
4c879a0
@webmaster128
Add example for multithreaded cache access
55f2fff
@webmaster128
Move supported_features, check_wasm and compile out of locking
b59223f
@webmaster128
Improve multithreading test
c3bf028
@webmaster128
Rename id -> checksum for consistency
2712a3e
@webmaster128
Remove outdated note on cache size
d758786
@webmaster128
Fiy typo: INSTANTION_THREADS -> INSTANTIATION_THREADS
eb07177
@webmaster128
Merge pull request #847 from CosmWasm/interior_mutability
be8176b 
Implement interior mutability consistently and run concurrency tests
@webmaster128
Run clippy on all tests
af7612b
@webmaster128
Merge pull request #849 from CosmWasm/lint-tests
e02f03d 
Run clippy on all tests
@webmaster128
Update schemars to 0.8.1
bb40a06
@webmaster128
Re-enable field_reassign_with_default clippy rule
3eb79ac
@webmaster128
Merge pull request #851 from CosmWasm/reenable-field_reassign_with_de…
ac9a1e2 
…fault

Re-enable field_reassign_with_default
@webmaster128
Rename KV to Pair
a11e27c
@webmaster128
Adapt codebase to Rust 1.51.0 compiler and clippy warnings
c265c6b
@webmaster128
Use const generics for Binary::to_array
85ef6e7
@webmaster128
Use const generics for array to Binary conversions
4896591
@webmaster128
Document min Rust version to be 1.51.0
a73a4db
@webmaster128
Use rust:1.51.0 in CI
e683692
@webmaster128
Use rust-optimizer:0.10.9
a19bda2
@webmaster128
Run clippy on tests in check_workspace.sh
78b00f9
@webmaster128
Remove unnecessary shorthands
9238b32
@webmaster128
Iplement From instead of Into to make clippy happy
34ad292
@webmaster128
Merge pull request #852 from CosmWasm/upgrade-to-rust-1.51.0
9a4c176 
Upgrade to Rust 1.51.0
@shiki-tak shiki-tak force-pushed the shiki_tak/issues/121 branch 2 times, most recently from ee7cf65 to e258f1a Compare June 10, 2021 10:59
@shiki-tak shiki-tak force-pushed the shiki_tak/issues/121 branch from e258f1a to ac5ca78 Compare June 10, 2021 11:27
@shiki-tak shiki-tak removed the WIP label Jun 14, 2021
@brew0722
Copy link
Contributor

We decided not to use the develop branch, so I think we need to change the target to the main branch.
Others are LGTM.

@shiki-tak shiki-tak changed the base branch from develop to main June 15, 2021 06:13
@whylee259
Copy link
Contributor

whylee259 commented Jun 17, 2021 •
edited
Loading

In packages/vm/src/testing/mock.rs,
The upstream has removed canonicalize_cost and humanize_cost from MockApi, but the merge results leave them as before. Is it intended?

@shiki-tak
Copy link
Contributor Author

In packages/vm/src/testing/mock.rs,
The upstream has removed canonicalize_cost and humanize_cost from MockApi, but the merge results leave them as before. Is it intended?

You mean this?
https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dR127

The upstream MockApi uses GAS_COST_CANONICALIZE as a constant, but since we added the following test, we left it as the test fails with a constant.
https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dR265

@whylee259
Copy link
Contributor

whylee259 commented Jun 17, 2021 •
edited
Loading

minor

https://github.com/line/cosmwasm/pull/122/files#diff-2503556807c26c0cb326754f3c3184ec7f62630ec3c6f548e5a6607947f8023dL52-L58
The deprecated initializer can be removed.

@shiki-tak shiki-tak force-pushed the shiki_tak/issues/121 branch from be3d12e to 8e2e800 Compare June 22, 2021 05:41
@shiki-tak shiki-tak force-pushed the shiki_tak/issues/121 branch from 8e2e800 to ed9b9e7 Compare June 22, 2021 05:58
@shiki-tak shiki-tak force-pushed the shiki_tak/issues/121 branch from 130462b to 13b89e2 Compare June 22, 2021 06:14
@whylee259 whylee259 merged commit 25690c3 into main Jun 22, 2021
@whylee259 whylee259 deleted the shiki_tak/issues/121 branch July 7, 2021 04:53
@shiki-tak shiki-tak restored the shiki_tak/issues/121 branch December 2, 2021 06:21
@loloicci loloicci deleted the shiki_tak/issues/121 branch June 3, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whylee259 whylee259 whylee259 approved these changes

@loloicci loloicci loloicci approved these changes

@brew0722 brew0722 brew0722 approved these changes

Assignees

@shiki-tak shiki-tak

Labels
VM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate v0.14(w/ wasmd)
8 participants
@shiki-tak @brew0722 @whylee259 @loloicci @maurolacy @webmaster128 @yihuang @ethanfrey