-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adjust set command to support version ranges #146
Conversation
Coverage Report •
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest you don't attempt to invent your own version range syntax. There are smarter people than us working on that sort of thing and they came up with existing solutions, which additionally fit nicely into the CycloneDX ecosystem. Primarily, purl's proposed version range specification comes to mind:
It is already being referenced by CycloneDX
This would largely render version_processing.py
obsolete and therefore cuts down the code in this PR by more than half. Its always great to have less code to maintain!
ff71a33
to
83ae809
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a lot better than the last attempt. Good job!
A few comment remain but mostly minor stuff.
6944a21
to
3fcc463
Compare
Is it intentional, that a version range cannot be set via the command-line, only using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost good to go!
It was not... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CBeck-96 please change the flag according to our guidelines and adjust your example, so that everybody understands when the version_range would apply or not, as otherwise everybody would be required to read the univers-specification.
Further, please check if the use of the term "schema" is really required or you could stick to only use "range".
2d38fbd
to
5174308
Compare
…from the command line
ff226af
to
6a163ed
Compare
Expand set to allow the processing for version ranges.