Hackathon #25
Merged
Hackathon #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimalvovs
commented
May 20, 2024
modules/local/spacemarkers.nf
Outdated
| features <- getSpatialFeatures("$cogapsResult"); | ||
| spPatterns <- cbind(coords, features); | ||
| barcodes <- intersect(rownames(features), rownames(coords)) | ||
| spPatterns <- cbind(coords[barcodes,], features[barcodes,]); |
There was a problem hiding this comment.
it may be shorter to express the same with base::merge
dimalvovs
commented
May 20, 2024
modules/local/spacemarkers.nf
Outdated
| spPatterns <- cbind(coords, features); | ||
| barcodes <- intersect(rownames(features), rownames(coords)) | ||
| spPatterns <- cbind(coords[barcodes,], features[barcodes,]); | ||
|
|
||
| saveRDS(spPatterns, file = "${prefix}/spPatterns.rds"); | ||
|
|
||
| #temp fix to remove barcodes with no spatial data | ||
| barcodes <- intersect(rownames(spPatterns), colnames(dataMatrix)) |
There was a problem hiding this comment.
this seems duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a code review template, it will be displayed after each pull request. We do code reviews because we care about quality of our codebase and because we care about long-term development goals. We do not do code reviews to blame the ones who contribute. There is no seniority in this process and there is no perfect code, we just want to avoid storing code that is not OK.
For the submitter
For the approver