-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MixedDofhandler support #70
Conversation
189b247
to
c18e34b
Compare
… the Shader Buffer
c18e34b
to
ceb0623
Compare
d943fac
to
7141259
Compare
should we merge this and bump a version @termi-official before the dofhandlers are merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should. I left a suggestion to make the PR non-breaking for users.
for some reason the docs only show the first figure of a page, don't know what's going wrong there |
Regression in WGLMakie or compat issue maybe? I quickly looked into this and could not find anything suspicious. You could also try to give the examples different numbers. Maybe the regression hides there. Edit: https://github.com/Ferrite-FEM/FerriteViz.jl/blob/master/docs/Manifest.toml#L1305 we can try to just update WGLMakie.jl |
besides WGLMakie bug ok? |
Yes. But I can reproduce the problem locally on my machine across different WGLMakie versions. Plotting the figures individually with WGLMakie works tho. |
I guess it's more of a JSServe issue then |
Maybe. I am more wondering why this one is completely silent. I could not find any error message or warning related t this in neither the browser console, nor the terminal. Maybe bisect which commit causes the issue? We should also think about a way to capture this automatically in CI, so we can react earlier. |
We can't do more than #71 If JSServe fails silently we can't do much about it |
We should be able to check somehow if any of the plot panels in the html is empty. Not straight forward tho. |
521fea7
to
1bb3c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update to JSServe 2.2.3 works locally with the current state. So we just have to wait for the register to finish and can finally merge. Thanks Maxi (and Simon)!
New features
MixedDofHandler
NaN
)docs/src/ferrite-examples/mixedgrid.jl
example which requiresFerriteGmsh
Requirements
so docs currently don't work, they pull the latest releaseconstrained the Ferrite version to latest releaseFuture changes
DofHandler
specific things as soon as MergingDofHandler
andMixedDofHandler
Ferrite.jl#624 is closed