Merge Debian and Docker version code #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR merges the Debian and Docker version generation code by introducing a unified "versions" type to consolidate logic for extracting Debian package versions and Docker image tags based on GitHub Actions environment variables.
- Introduces a new "versions" struct replacing the older images struct and associated functions.
- Refactors the version extraction functions for pull requests, branches, and tags while updating the related tests.
- Removes obsolete Docker-specific and Debian version functions to simplify the codebase.
Reviewed Changes
| File | Description |
|---|---|
| ferretdb_packaging/defineversion/main.go | Consolidates version extraction into a unified "versions" type and refactors control flow. |
| ferretdb_packaging/defineversion/main_test.go | Updates tests to validate the new "versions" struct output. |
| ferretdb_packaging/defineversion/docker_test.go | Removes previously redundant Docker version tests. |
| ferretdb_packaging/defineversion/docker.go | Removes deprecated functions and commented code; only retains dockerImageURL. |
| ferretdb_packaging/defineversion/debian.go | Removes obsolete Debian version helper functions. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
noisersup
approved these changes
Mar 5, 2025
AlekSi
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FerretDB/FerretDB#4725.