Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove branch from Debian package versions #32

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Remove branch from Debian package versions #32

merged 2 commits into from
Mar 4, 2025

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 4, 2025

To match Docker tags.

@AlekSi AlekSi added packages PRs that should build packages trust PRs that can access Actions secrets labels Mar 4, 2025
@AlekSi AlekSi self-assigned this Mar 4, 2025
@AlekSi AlekSi requested a review from Copilot March 4, 2025 05:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR simplifies the Debian package version naming by removing the branch indicator from the version string to align with Docker tags.

  • Removed branch handling logic to only support the "ferretdb" branch.
  • Updated Debian version formatting in the packaging code and corresponding expected outputs in tests.

Reviewed Changes

File Description
ferretdb_packaging/defineversion/debian.go Removed branch marker from version string and simplified branch handling logic.
ferretdb_packaging/defineversion/main_test.go Adjusted expected Debian version strings in tests to match the updated version format.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

ferretdb_packaging/defineversion/debian.go:98

  • [nitpick] The function now only supports the 'ferretdb' branch; consider updating the function's comment to reflect this limitation for clarity.
if branch != "ferretdb" {

ferretdb_packaging/defineversion/debian.go:99

  • Consider including the supported branch ('ferretdb') in the error message to provide clearer guidance for developers.
return "", fmt.Errorf("unhandled branch %q", branch)

ferretdb_packaging/defineversion/main_test.go:153

  • Consider adding tests for scenarios when an unsupported branch is passed to ensure the error path is properly covered.
expectedDebian: "0.100.0~ferretdb",
@AlekSi AlekSi merged commit 6092471 into ferretdb Mar 4, 2025
25 checks passed
@AlekSi AlekSi deleted the branch branch March 4, 2025 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant