-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Docker tags #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Docker tagging logic to incorporate an additional version parameter (pgVersion) into the tag formats used for pull requests, branch builds, and tag builds. Key changes include passing pgVersion as a parameter to the Docker version functions, updating the tag format strings accordingly, and modifying tests to expect the new tag format.
Reviewed Changes
File | Description |
---|---|
ferretdb_packaging/defineversion/docker.go | Updated Docker version functions to inject pgVersion into tags and adjusted function signatures and tag formatting logic. |
ferretdb_packaging/defineversion/main_test.go | Updated tests to expect Docker tags that include the pgVersion value. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
ferretdb_packaging/defineversion/docker.go:115
- The comment for the defineDockerVersionForTag function is incorrect. Please update it to reflect the proper function name and purpose, for example: '// defineDockerVersionForTag defines Docker image names and tags for tag builds.'
// defineDockerVersionForBranch defines Docker image names and tags for tag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
No description provided.