Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more Docker tags #30

Merged
merged 4 commits into from
Mar 4, 2025
Merged

Add more Docker tags #30

merged 4 commits into from
Mar 4, 2025

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 4, 2025

No description provided.

@AlekSi AlekSi added the not ready Issues that are not ready to be worked on; PRs that should skip CI label Mar 4, 2025
@AlekSi AlekSi self-assigned this Mar 4, 2025
@AlekSi AlekSi changed the title Tweak tags Tweak Docker tags Mar 4, 2025
@AlekSi AlekSi changed the title Tweak Docker tags Add more Docker tags Mar 4, 2025
@AlekSi AlekSi added packages PRs that should build packages trust PRs that can access Actions secrets and removed not ready Issues that are not ready to be worked on; PRs that should skip CI labels Mar 4, 2025
@AlekSi AlekSi marked this pull request as ready for review March 4, 2025 05:16
@AlekSi AlekSi enabled auto-merge (squash) March 4, 2025 05:16
@AlekSi AlekSi requested review from chilagrow and Copilot March 4, 2025 05:16

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Docker tagging logic to incorporate an additional version parameter (pgVersion) into the tag formats used for pull requests, branch builds, and tag builds. Key changes include passing pgVersion as a parameter to the Docker version functions, updating the tag format strings accordingly, and modifying tests to expect the new tag format.

Reviewed Changes

File Description
ferretdb_packaging/defineversion/docker.go Updated Docker version functions to inject pgVersion into tags and adjusted function signatures and tag formatting logic.
ferretdb_packaging/defineversion/main_test.go Updated tests to expect Docker tags that include the pgVersion value.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

ferretdb_packaging/defineversion/docker.go:115

  • The comment for the defineDockerVersionForTag function is incorrect. Please update it to reflect the proper function name and purpose, for example: '// defineDockerVersionForTag defines Docker image names and tags for tag builds.'
// defineDockerVersionForBranch defines Docker image names and tags for tag.
chilagrow
chilagrow previously approved these changes Mar 4, 2025
Copy link
Member

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AlekSi AlekSi disabled auto-merge March 4, 2025 05:25
@AlekSi AlekSi enabled auto-merge (squash) March 4, 2025 05:25
@AlekSi AlekSi disabled auto-merge March 4, 2025 05:25
@AlekSi AlekSi merged commit aa5e310 into ferretdb Mar 4, 2025
9 of 22 checks passed
@AlekSi AlekSi deleted the tweak-tags branch March 4, 2025 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants