Enable other registries #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR enables support for using additional Docker registries when defining image versions. The changes uncomment and activate the previously disabled Docker image definitions in both branch and tag functions, and update the tests to reflect the new expected image lists.
- Uncomment Docker image appends in branch and tag functions.
- Update test expectations accordingly.
Reviewed Changes
| File | Description |
|---|---|
| ferretdb_packaging/defineversion/docker.go | Uncommented and activated image registry entries for both branch and tag |
| ferretdb_packaging/defineversion/main_test.go | Updated expected image lists to reflect the enabled registries |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.