Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks #26

Merged
merged 3 commits into from
Mar 3, 2025
Merged

Minor tweaks #26

merged 3 commits into from
Mar 3, 2025

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 3, 2025

No description provided.

@AlekSi AlekSi added packages PRs that should build packages trust PRs that can access Actions secrets labels Mar 3, 2025
@AlekSi AlekSi self-assigned this Mar 3, 2025
@Copilot Copilot bot review requested due to automatic review settings March 3, 2025 19:36

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR introduces minor tweaks to the packaging commands and testing outputs.

  • Introduces a new command-line flag "debian-only" in main.go to limit output to Debian package versions.
  • Updates the GitHub workflow and test expectations to reflect the new flag and table header format.
  • Adjusts the output formatting in docker.go and docker_test.go to use "Docker image" consistently.

Reviewed Changes

File Description
ferretdb_packaging/defineversion/main.go Added the "-debian-only" flag and updated conditional output logic.
.github/workflows/ferretdb_packages.yml Modified run commands to include the "-debian-only" flag and updated artifact names.
ferretdb_packaging/defineversion/docker_test.go Updated expected outputs in tests to match new image tags and table header formatting.
ferretdb_packaging/defineversion/docker.go Changed table header labels in dockerSummary for consistency with tests.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

AlekSi added 2 commits March 3, 2025 23:45
@AlekSi AlekSi merged commit 9e96940 into ferretdb Mar 3, 2025
9 of 21 checks passed
@AlekSi AlekSi deleted the tweaks branch March 3, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages PRs that should build packages trust PRs that can access Actions secrets
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant