Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v2 dev databases #1199

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Add v2 dev databases #1199

merged 1 commit into from
Mar 14, 2025

Conversation

chilagrow
Copy link
Member

Closes #1154.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@chilagrow chilagrow added the code/chore Dance tool code maintenance improvements label Mar 14, 2025
@chilagrow chilagrow self-assigned this Mar 14, 2025
@chilagrow chilagrow marked this pull request as ready for review March 14, 2025 01:50
@chilagrow chilagrow requested a review from AlekSi as a code owner March 14, 2025 01:50
@chilagrow chilagrow requested review from a team and noisersup March 14, 2025 01:51
@chilagrow chilagrow enabled auto-merge (squash) March 14, 2025 01:51
@AlekSi AlekSi requested a review from Copilot March 14, 2025 10:13

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for v2 dev databases by introducing new Docker Compose services, updating internal configuration, and adding new workload configurations. The key changes include:

  • Adding new Docker Compose services "ferretdb2-dev" and "ferretdb2-dev-secured" and a new postgres service "postgres-documentdb-dev".
  • Updating the internal configuration with connection strings for the new dev databases.
  • Incorporating new workload configuration entries across multiple example files.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
docker-compose.yml New services added to support ferretdb v2 dev databases
internal/configload/configload.go Added connection mappings for new dev databases
projects/ycsb-workloadc.yml Added workload config; naming inconsistency detected
projects/ycsb-workloadb.yml Added workload config; naming inconsistency detected
projects/mongo-tools.yml Updated workload config with correct naming for ferretdb2-dev
projects/ycsb-workloadc2.yml Added workload config; naming inconsistency detected
projects/ycsb-workloadb2.yml Added workload config; naming inconsistency detected
projects/python-example.yml Updated workload config with correct naming for ferretdb2-dev and secure
projects/ycsb-workloada.yml Added workload config; naming inconsistency detected
projects/dotnet-example.yml Updated workload config with correct naming for ferretdb2-dev and secure
projects/java-example.yml Updated workload config with correct naming for ferretdb2-dev and secure
projects/nodejs-example.yml Updated workload config with correct naming for ferretdb2-dev and secure
projects/ycsb-workloada2.yml Added workload config; naming inconsistency detected
Comments suppressed due to low confidence (6)

projects/ycsb-workloadc.yml:23

  • The service name 'ferretdb-dev' is inconsistent with the 'ferretdb2-dev' naming used in docker-compose and internal config; consider renaming it to 'ferretdb2-dev' for consistency.
  ferretdb-dev:

projects/ycsb-workloadb.yml:23

  • The service name 'ferretdb-dev' is inconsistent with the new naming convention 'ferretdb2-dev'; please update this to 'ferretdb2-dev' to match the docker-compose and config changes.
  ferretdb-dev:

projects/ycsb-workloadc2.yml:19

  • The new workload entry 'ferretdb-dev' does not follow the naming used in other parts of the project; consider renaming it to 'ferretdb2-dev'.
  ferretdb-dev:

projects/ycsb-workloadb2.yml:19

  • Renaming 'ferretdb-dev' to 'ferretdb2-dev' would maintain consistency with the docker-compose and config settings.
  ferretdb-dev:

projects/ycsb-workloada.yml:23

  • Consider renaming 'ferretdb-dev' to 'ferretdb2-dev' to align with the naming convention introduced in the docker-compose and configuration files.
  ferretdb-dev:

projects/ycsb-workloada2.yml:19

  • The service name 'ferretdb-dev' should be updated to 'ferretdb2-dev' for consistency with the new dev database nomenclature.
  ferretdb-dev:
@chilagrow chilagrow merged commit 2af6d94 into FerretDB:main Mar 14, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Dance tool code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move changes from our private v2 repo
2 participants