Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ambiguous comment #4382

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Remove ambiguous comment #4382

merged 1 commit into from
Jun 24, 2024

Conversation

chilagrow
Copy link
Member

@chilagrow chilagrow commented Jun 24, 2024

Description

Closes #<issue_number>.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@chilagrow chilagrow added the code/chore Code maintenance improvements label Jun 24, 2024
@chilagrow chilagrow self-assigned this Jun 24, 2024
@chilagrow chilagrow marked this pull request as ready for review June 24, 2024 01:44
@chilagrow chilagrow requested a review from a team as a code owner June 24, 2024 01:44
@chilagrow chilagrow requested review from AlekSi, rumyantseva, a team and noisersup June 24, 2024 01:44
@chilagrow chilagrow added this to the v1.22.0 milestone Jun 24, 2024
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (f87a2c2) to head (7bdec1d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4382      +/-   ##
==========================================
- Coverage   75.11%   74.03%   -1.09%     
==========================================
  Files         326      326              
  Lines       22343    22343              
==========================================
- Hits        16784    16541     -243     
- Misses       4363     4592     +229     
- Partials     1196     1210      +14     
Files Coverage Δ
internal/handler/msg_hello.go 76.00% <ø> (ø)

... and 29 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.42% <ø> (-2.83%) ⬇️
hana-1 ?
integration 67.42% <ø> (-2.87%) ⬇️
mongodb-1 4.95% <ø> (-0.01%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 43.93% <ø> (-11.15%) ⬇️
postgresql-2 44.89% <ø> (-8.74%) ⬇️
postgresql-3 42.97% <ø> (-9.64%) ⬇️
postgresql-4 40.31% <ø> (-0.07%) ⬇️
postgresql-5 43.72% <ø> (-0.06%) ⬇️
sqlite-1 43.16% <ø> (-10.87%) ⬇️
sqlite-2 43.97% <ø> (-8.67%) ⬇️
sqlite-3 42.20% <ø> (-9.43%) ⬇️
sqlite-4 39.45% <ø> (ø)
sqlite-5 43.04% <ø> (-0.05%) ⬇️
unit 33.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@chilagrow chilagrow enabled auto-merge (squash) June 24, 2024 02:15
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@chilagrow chilagrow merged commit 9c2a943 into FerretDB:main Jun 24, 2024
31 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants