Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup awaitData tailable cursor #3915

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Dec 28, 2023

Description

Closes #2283.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8d94bd) 74.87% compared to head (65a3e2a) 73.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3915      +/-   ##
==========================================
- Coverage   74.87%   73.87%   -1.00%     
==========================================
  Files         330      330              
  Lines       25665    25671       +6     
==========================================
- Hits        19217    18965     -252     
- Misses       5280     5577     +297     
+ Partials     1168     1129      -39     
Files Coverage Δ
internal/handler/msg_getmore.go 84.27% <100.00%> (+0.38%) ⬆️

... and 15 files with indirect coverage changes

Flag Coverage Δ
filter-true 70.56% <100.00%> (-1.31%) ⬇️
hana-1 ?
integration 70.56% <100.00%> (-1.31%) ⬇️
mongodb-1 5.22% <0.00%> (-0.01%) ⬇️
postgresql-1 50.77% <100.00%> (+0.02%) ⬆️
postgresql-2 52.19% <100.00%> (+0.03%) ⬆️
postgresql-3 50.29% <92.30%> (+0.11%) ⬆️
sqlite-1 49.92% <100.00%> (-0.08%) ⬇️
sqlite-2 51.27% <100.00%> (+0.07%) ⬆️
sqlite-3 49.41% <92.30%> (+0.12%) ⬆️
unit 30.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review December 28, 2023 21:04
@noisersup noisersup requested a review from a team as a code owner December 28, 2023 21:04
@noisersup noisersup added the code/feature Some user-visible feature is not implemented yet label Dec 28, 2023
@noisersup noisersup added this to the Next milestone Dec 28, 2023
@noisersup noisersup requested review from a team and henvic December 28, 2023 21:05
@noisersup noisersup enabled auto-merge (squash) December 28, 2023 21:05
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noisersup noisersup merged commit 8c865ff into FerretDB:main Jan 2, 2024
@noisersup noisersup deleted the awaitdata-cleanup-2283 branch January 2, 2024 13:50
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/feature Some user-visible feature is not implemented yet labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support tailable cursors
4 participants