updates for conda #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that Vivek. I'll take a look when I am not so tired, just waiting at the airport for late night flight.... |
|
@FelixKrueger just pinging again as a reminder. :) |
|
Don't worry, the email is still in my inbox. The issue is that it is a bank holiday and I am abroad on vacations in gorgeous weather... I'll try to look soon though. |
|
oh wow. I thought you forgot :) No problem. Enjoy your holidays 👍 |
|
Sorry for taking to so long, looks all fine. Cheers, Felix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @FelixKrueger
I have added SNPsplit (v0.3.3) to bioconda and the addition went ok, but then I realized the use of
/usr/bin/perl -wmadetag2sortunusable. I have added the fix for that, and another fix removing extra--dircommand. Could you please add these changes and make a new release (0.3.4) ? I edited the version names already in the files, but might need fixed. Once you do this i can add a new recipe to bioconda and we would have this working.Thanks
Vivek