feat: 키캡 만들기 #3
Merged
feat: 키캡 만들기 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 12, 2023 12:55
- 예제 코드 제거 - axesHelper, Camera/OrbitControls 추가
|
레포 수정권한이 없어서 그런가 Reviewer/Asignee 설정도 못하고 머지도 못하네요 ㅠ.ㅠ |
behoney
reviewed
Feb 12, 2023
Comment on lines
+6
to
+8
| const frontLight = useRef<DirectionalLight>(null!) | ||
| const backShadow = useRef<DirectionalLight>(null!) | ||
|
|
There was a problem hiding this comment.
null! 보다 좋은 핸들링을 찾고 싶은데, 마땅한 방법이 떠오르지 않네요 :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
작업내용
키캡 잔여 이슈
참고사항
키캡 Geometry 간단 설명
- 위에서 정의한 값들과 좌표를 토대로 위와 같이 삼각형들을 이어 만든 것입니다.