Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: emit caller info for deprecated methods #116

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Conversation

stackmystack
Copy link
Contributor

No description provided.

@akimd
Copy link
Contributor

akimd commented Nov 6, 2024

It would be nice to tag the warning as :deprecated.

https://docs.ruby-lang.org/en/3.3/Warning.html

@stackmystack
Copy link
Contributor Author

It would be nice to tag the warning as :deprecated.

https://docs.ruby-lang.org/en/3.3/Warning.html

FTR, we discussed in person, and this is problematic: it requires users to turn on deprecated warnings explicitly and they will go unnoticed since they're turned off by default.

@stackmystack stackmystack merged commit c2ab123 into master Nov 8, 2024
187 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants