-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend XMLStreamWriter validation test coverage #191
Conversation
expected error occurred
validation wherever we test the reader validation
…verbose"' not thrown from RepairingNsStreamWriter when validating against a DTD schema
…idating with SimpleNsStreamWriter
Would be happy to merge this. Since there are non-test changes, one thing we need to have CLA (if not received yet, apologies if I missed it). One from Jackson repo: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf is one we use; it is usually easiest to print, fill & sign, scan/photo, email to Once I have CLA it's good for all future contributions. Looking forward to merging this, thank you! |
I asked our legal team for an approval. |
Thank you @ppalaga . |
Since the only remaining changes here are test improvements, I can merge without CLA -- will do so. |
@cowtowncoder our Legal team did not approve the CLA you pointed me to. The main concern lies in the broad scope of the copyright license, particularly with the request for joint ownership. |
Yes CCLA makes sense then. Have had a few company submit that, including some of FAANGs; no real difference for us. |
@cowtowncoder this is a preparation for the fix of #179: