Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified Signer the remove DefaultHeaders from Request. #29

Merged
merged 9 commits into from
Jun 27, 2019
Merged

Modified Signer the remove DefaultHeaders from Request. #29

merged 9 commits into from
Jun 27, 2019

Conversation

daniel-rck
Copy link
Contributor

@daniel-rck daniel-rck commented Jun 24, 2019 •
edited by FantasticFiasco
Loading

Description

Fixes #28

Checklist

  • I have squashed my commits into a single one with a message that aligns with the contributing guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@FantasticFiasco FantasticFiasco mentioned this pull request Jun 24, 2019
Closed
@FantasticFiasco
Copy link
Owner

Don't worry about the failing CI, I caused it but will fix it before we merge this pull request.

@FantasticFiasco
Copy link
Owner

I am a couple commits away from being finished. But in the meantime I am forced to do changes to your master that won't work for you in Mono. I will try to be quick about it. If it is a problem for you, create a branch from your first commit and take a dependency on that until I am finished here.

Thanks!

@FantasticFiasco
refactor: move assignment of default headers
b0bdd87 
Lets move the assignment of default headers, thus not affecting the
actual request message at all, but instead introduce the default headers
to the signing algorithm in a more direct way.
@daniel-rck
Copy link
Contributor Author

Don't feel pushed, I'm using my own fork until you release a stable version :)

@FantasticFiasco
Copy link
Owner

But I am pushing changes to your fork right now, in order to get them into the pull request, thus possibly affecting your development environment.

@daniel-rck
Copy link
Contributor Author

Ah I see. Then I'll work with a local branch.

@FantasticFiasco FantasticFiasco merged commit a415cc9 into FantasticFiasco:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default Request Headers are double added on Android
2 participants
@daniel-rck @FantasticFiasco