skip unsignable headers #1207
Merged
skip unsignable headers #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00f1a53 to
ae7dff4
Compare
ae7dff4 to
45f3e32
Compare
cfbao
commented
Nov 30, 2024
|
I'm sorry it is taking this time, but we will eventually get there. I'm looking into extending the tests running against the API Gateway. |
cfbao
commented
Dec 23, 2024
Comment on lines
+264
to
+270
| var headerValue = (string)testCase[0]; | ||
|
|
||
| // Exclude the following headers due to them failing | ||
| if (headerValue is "Range" or "Transfer-Encoding") | ||
| { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Should it have been var headerValue = (string)testCase[1];?
Maybe then we don't need to skip Range or Transfer-Encoding headers in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Checklist