Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added retry_on_error to the conn object returned by the Is_sentinel f… #69

Merged
merged 2 commits into from
Oct 13, 2024
Merged

added retry_on_error to the conn object returned by the Is_sentinel f… #69

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4faa66a
added retry_on_error to the conn object returned by the Is_sentinel f…
MuhammadQadora Oct 13, 2024
fde2062
There is no need to add retry and retry_on_error
MuhammadQadora Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion falkordb/falkordb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@

if Is_Sentinel(conn):
self.sentinel, self.service_name = Sentinel_Conn(conn, ssl)
conn = self.sentinel.master_for(self.service_name, ssl=ssl, retry=retry)
conn = self.sentinel.master_for(self.service_name, ssl=ssl)

Check warning on line 126 in falkordb/falkordb.py

View check run for this annotation

Codecov / codecov/patch

falkordb/falkordb.py#L126 

Added line #L126 was not covered by tests
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add test coverage for the modified line

The static analysis tool indicates that the modified line 126 is not covered by tests. Consider adding test cases to cover this change and ensure the new behavior works as expected.

Would you like assistance in generating test cases for this change?

🧰 Tools
🪛 GitHub Check: codecov/patch

[warning] 126-126: falkordb/falkordb.py#L126
Added line #L126 was not covered by tests


if Is_Cluster(conn):
conn = Cluster_Conn(
Expand Down