No-op clientTick #34
Closed
No-op clientTick #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This will obliterate anything e.g Injects
FakeDomi
added a commit
that referenced
this pull request
Nov 6, 2023
|
I'm now preventing the ticker from even being created in version 1.5 and that optimization can hot reload after changing the in-game config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently as it is, models are static. But the clientTick function still runs anyway, and can be significant. For instance, a bunker with lots of chests took up about 2-3% of the render thread time.
This PR brings some minor cleanup, and turns
clientTickinto a no-op. As well, a 2nd PR to master branch is provided with merge conflicts resolved.