Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use packr for config.yaml #97

Merged
merged 1 commit into from
May 17, 2019
Merged

use packr for config.yaml #97

merged 1 commit into from
May 17, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 17, 2019

No description provided.

@rbren
Copy link
Contributor Author

rbren commented May 17, 2019

Had to move config.yaml to a separate directory, as packr needs a directory as input, and every file in that directory ends up in the binary (so root directory is a bad idea).

@rbren rbren force-pushed the rb/assets branch 2 times, most recently from 27dc1fe to 6a5dd9f Compare May 17, 2019 14:20
@rbren rbren requested a review from robscott May 17, 2019 14:27
@rbren
Copy link
Contributor Author

rbren commented May 17, 2019

Fixes #94 and #93

robscott
robscott approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the fix!

@rbren rbren merged commit 399924a into master May 17, 2019
@robscott robscott mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbren @robscott