Much more granular RBAC permissions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
approved these changes
May 16, 2019
There was a problem hiding this comment.
Looks good! Thanks for doing this Rob, looks like quite a rabbit hole. Definitely good that the dash has stricter permissions now
Corey/EJ may be able to catch something in the YAML that I'd miss, but so long as the dash and webhook are working properly I think we're safe to merge.
…ok components to allow for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was quite the rabbit hole, and involved splitting up dashboard and webhook deploy components more to ensure that the dashboard didn't get any unnecessary access. I also ran into an interesting problem where deployments with a
extensionsapi version were not getting intercepted by the webhook - this PR fixes that. Since controller-runtime's webhook component insists on logging to a file in/tmp, I ended up adding an emptyDir volume mount so we could continue to specifyreadOnlyRootFilesystemto ensure we're meeting our own standards here.