-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update logo #85
update logo #85
Conversation
rbren
commented
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on! Only thought is that the logo file size is quite large, maybe we can resize it to be more web friendly? Does this also update the logo referenced in the readme? I think the logo could also be a tad smaller in the layout itself, but I could be wrong on that.
93e90cc
to
787d34f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting the new logo in! I'm not sure this makes sense, but it might be cool to have all the things kinda lined up with the content below that's already indented 30px left and right within the cards. I'm really not sure about this, so feel free to disregard it, but if it does make sense, that would mean something like this:
.navbar .navbar-right {
padding: 0px 30px;
}
.navbar .logo {
margin: 5px 30px;
}
.navbar span.oss-text {
margin: 3px 0;
}
.kubernetes-overview {
margin: 0 10px;
}
I actually like both of those, I'll defer to you. Before it was a bit weird because I think the RO logo had different padding than the Polaris one, but either of these feel balanced to me. |