Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explanations for each error #75

Merged
merged 2 commits into from
May 9, 2019
Merged

Add explanations for each error #75

merged 2 commits into from
May 9, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented May 8, 2019

I don't love how the info icons look, so happy to take any suggestions there.

Screen Shot 2019-05-08 at 12 16 12 PM

Screen Shot 2019-05-08 at 12 16 38 PM

rbren added 2 commits May 8, 2019 14:54
@rbren
add new deps
2c1c4c2
@rbren
Add explanations for each error
bd2da76 
first pass

add info links to dashboard
@rbren rbren requested a review from robscott May 8, 2019 16:17
robscott
robscott approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for adding the docs! I'd be interested in seeing how we can improve how we link out to them in the future, but this is 1000x better than the lack of doc references we had before.

@rbren rbren merged commit 7c34d6f into master May 9, 2019
@robscott robscott deleted the rb/error-explanations branch May 16, 2019 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbren @robscott