Save last podspec when walking owner hierarchy #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makoscafee
approved these changes
Apr 20, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes # #725
Checklist
Description
What's the goal of this PR?
Sometimes the ultimate owner of a Pod does not contain a
podSpec. Examples include the Prometheus Operator'sPrometheusCRD and Argo'sRolloutCRD.The goal here is to make sure we still capture pod-level findings for these resources.
What changes did you make?
isFinalKind, which was an overly-specific heuristic for fixing this issue for the Prometheus CRDpodSpecas we walk up the owner hierarchy. If we reach a resource that doesn't have apodSpec, use the one from its childWhat alternative solution should we consider, if any?
I think this is probably the best solution