Adding initial tests + CI #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| context: org-global | ||
| filters: | ||
| tags: | ||
| only: /^testing-.*/ |
There was a problem hiding this comment.
why only on testing tags? I kind of feel like we should test all PRs and/or branches. thoughts?
| cv.validateResources(expected) | ||
|
|
||
| assert.Len(t, cv.Failures, 0) | ||
| } |
There was a problem hiding this comment.
I feel like these tests could all be table tests using subtests. Thoughts?
|
|
||
| conf "github.com/reactiveops/fairwinds/pkg/config" | ||
| types "github.com/reactiveops/fairwinds/pkg/types" | ||
| "github.com/stretchr/testify/assert" |
There was a problem hiding this comment.
this assert library is awesome. i haven't used it before. I love that is has mocks. I want to try those out! One of my favorite things is to AssertCalled.
50c82d8 to
62a9c37
Compare
62a9c37 to
5715c25
Compare
JessicaGreben
approved these changes
Dec 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not particularly pretty, but this gets us some basic tests + CI.