Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prerelease Cleanup #68

Merged
merged 3 commits into from
Apr 29, 2019
Merged

Prerelease Cleanup #68

merged 3 commits into from
Apr 29, 2019

Conversation

robscott
Copy link
Contributor

This PR does a few things:

  • Stops the webhook from being installed by default (changing a default value in the Helm chart + splitting up deploy/all into deploy/dashboard and deploy/webhook).
  • Adds a bunch of logging, standardizing on the use of logrus throughout
  • Fixes some deploy configuration for the webhook
  • Actually outputs webhook error messages again

rbren
rbren reviewed Apr 29, 2019
View reviewed changes
@robscott robscott merged commit 27e742f into master Apr 29, 2019
@robscott robscott deleted the rs/prerelease branch April 29, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robscott @rbren