skip incomplete or broken YAML - warn user #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rbren
approved these changes
Mar 23, 2022
Co-authored-by: Robert Brennan <accounts@rbren.io>
|
Hey! Can we merge this PR? I think it's a pretty interesing feature or provide some mecanism to ignore some paths |
Fairwinds Insights CI Report✅ No new Action Items detected! |
makoscafee
reviewed
Jun 7, 2022
pkg/kube/resources.go
Outdated
| logrus.Errorf("Error parsing YAML: (%v)", err) | ||
| return err | ||
| } | ||
| return resources.addResourceFromString(spec) |
There was a problem hiding this comment.
this will only add Resource from the first spec and ignore others.
|
@intrand mind signing the CLA? |
|
signed. looks like there's still a test that's failing @makoscafee |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
visitFile()(WalkFunc forfilepath.Walk()) to log parsing failures and continue (eg, patch files; fixes Polaris fails to parse/ignore Kustomization yaml JSONPatch files #667)