Add version, cluster stats to output and UI #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecbe9f3 to
fcea4d6
Compare
robscott
reviewed
Apr 22, 2019
pkg/validator/fullaudit.go
Outdated
| @@ -3,12 +3,28 @@ package validator | |||
| import ( | |||
| conf "github.com/reactiveops/fairwinds/pkg/config" | |||
| "github.com/reactiveops/fairwinds/pkg/kube" | |||
| k8smeta "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
There was a problem hiding this comment.
This is a really tiny thing, but most places I've seen this package included, including the one other place in this project, it's referred to as metav1, not sure there's any great reason to stick with that, just not what I'm used to in k8s code.
robscott
approved these changes
Apr 22, 2019
robscott
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample output as of now:
{ "FairwindsOutputVersion": "0.0", "ClusterSummary": { "Results": { "Successes": 160, "Warnings": 54, "Errors": 46 }, "Version": "1.10", "Nodes": 6, "Pods": 50, "Namespaces": 8 }, "NamespacedResults": { "cert-manager": { "Summary": { "Successes": 31, "Warnings": 12, "Errors": 8 }, "Results": [ { "Name": "cert-manager", "Type": "Deployment", "Summary": { "Successes": 13, "Warnings": 4, "Errors": 0 }, "ContainerResults": null, "PodResults": [ { "Name": "", "Messages": [ { "Message": "Host alias is not configured", "Type": "success" } ] } ] } ] } } }