Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for reporting #4

Merged
merged 2 commits into from
Dec 20, 2018
Merged

add support for reporting #4

merged 2 commits into from
Dec 20, 2018

Conversation

JessicaGreben
Copy link
Contributor

@JessicaGreben JessicaGreben commented Dec 19, 2018 •
edited
Loading

This PR creates:

  • a types package to avoid circular imports
  • a report package that formats the results of the validation checks

robscott
robscott approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thanks!

@JessicaGreben JessicaGreben merged commit 8a565d1 into master Dec 20, 2018
@JessicaGreben JessicaGreben deleted the jg/add-reporting-support branch December 20, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JessicaGreben @robscott