Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create capabilitiesAdded and capabilitiesDropped IDs #207

Merged
merged 2 commits into from
Oct 2, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Sep 20, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #207 into master will increase coverage by 0.43%.
The diff coverage is 89.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   80.71%   81.15%   +0.43%     
==========================================
  Files          11       11              
  Lines         700      711      +11     
==========================================
+ Hits          565      577      +12     
+ Misses        109      107       -2     
- Partials       26       27       +1
Impacted Files Coverage Δ
pkg/validator/container.go 94.42% <89.36%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3ab06...f224a7d. Read the comment docs.

Copy link
Contributor

@kimschles kimschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

If I understand this code correctly, you've added the addID variable which is set to the value of "capabilitiesAdded" and, dropID variable which is set to the value of "calpabilitiesDropped" and changed the value of id to "capabilitiesNotDropped" which gives the addSuccess and addFailure functions more descriptive information about the success or failure they report regarding the security capabilities check.

I ran this locally on my machine to manually test it, as well as running the tests from my computer.

Thank you for updating the messages and the tests to account for these changes.

@rbren rbren merged commit 434b1f6 into master Oct 2, 2019
@rbren rbren deleted the rb/capabilities-ids branch October 2, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants