Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 0.5.0 #205

Merged
merged 3 commits into from
Nov 6, 2019
Merged

update to 0.5.0 #205

merged 3 commits into from
Nov 6, 2019

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Sep 18, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files          12       12           
  Lines         748      748           
=======================================
  Hits          593      593           
  Misses        130      130           
  Partials       25       25

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ab851...6a199fe. Read the comment docs.

@rbren
Copy link
Contributor Author

rbren commented Sep 18, 2019

Not sure why nodeSelector and tolerations changed (maybe I updated helm?), but kubectl doesn't seem to mind.

Comment on lines +219 to +221
nodeSelector:
tolerations:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these changes intentional - it's not mentioned in the commit message and I wanted to assure it wasn't an IDE formatting thing so I can make sure mine is setup the same way

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is due to a Helm update (I'm on 2.13.0 now)

Copy link
Contributor

@jordandoig jordandoig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rbren rbren merged commit 3d07ce8 into master Nov 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the rb/update-version branch November 6, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants