Wl/config url #181
Wl/config url #181
Conversation
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 84.12% 85.01% +0.89%
==========================================
Files 9 9
Lines 529 534 +5
==========================================
+ Hits 445 454 +9
+ Misses 65 58 -7
- Partials 19 22 +3
Continue to review full report at Codecov.
|
|
Looks great! Just one change re: error handling and I think this is good to merge. Bonus: you can try adding another test that doesn't start an HTTP server (so that the HTTP request fails), and check to make sure you get the right error message. That would catch the current bug. |
…o Http server is configured
… into wl/config-URL
pkg/config/config.go
Outdated
| } | ||
| if err != nil { | ||
| return Configuration{}, err | ||
| if err != nil { |
There was a problem hiding this comment.
This still has to go outside the else statement, or the err on line 131 won't get caught
pkg/config/config.go
Outdated
| if path == "" { | ||
| rawBytes, err = configBox.Find("config.yaml") | ||
| if err != nil { |
There was a problem hiding this comment.
Once you move the if err != nil below, this check can go away, since it'll be handled outside the if/else.
|
Looking good! Just one more small change |
Expanded ParseFile to include URL's and added a test for it.