fix missing PDB check (#1027)

FairwindsOps · Feb 13, 2024 · e60793a · e60793a
1 parent c8394bf
commit e60793a
Show file tree

Hide file tree

Showing 4 changed files with 40 additions and 8 deletions.
diff --git a/checks/missingPodDisruptionBudget.yaml b/checks/missingPodDisruptionBudget.yaml
@@ -9,12 +9,18 @@ schema:
   '$schema': http://json-schema.org/draft-07/schema
   type: object
   properties:
-    metadata:
+    spec:
       type: object
       properties:
-        labels:
+        template:
           type: object
-          minProperties: 1
+          properites:
+            metadata:
+              type: object
+              properties:
+                labels:
+                  type: object
+                  minProperties: 1
 additionalSchemaStrings:
   policy/PodDisruptionBudget: |
     type: object
@@ -30,7 +36,7 @@ additionalSchemaStrings:
               matchLabels:
                 type: object
                 anyOf:
-                {{ range $key, $value := .metadata.labels }}
+                {{ range $key, $value := .spec.template.metadata.labels }}
                 - properties:
                     "{{ $key }}":
                       type: string

diff --git a/test/checks/missingPodDisruptionBudget/failure.wrong-place.yaml b/test/checks/missingPodDisruptionBudget/failure.wrong-place.yaml
@@ -0,0 +1,23 @@
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+  name: zookeeper
+  labels:
+    app.kubernetes.io/name: zookeeper
+    foo: bar
+spec:
+  template:
+    spec:
+      containers:
+      - name: zookeeper
+        image: zookeeper
+---
+apiVersion: policy/v1
+kind: PodDisruptionBudget
+metadata:
+  name: zookeeper-pdb
+spec:
+  minAvailable: 2
+  selector:
+    matchLabels:
+      app.kubernetes.io/name: zookeeper
diff --git a/test/checks/missingPodDisruptionBudget/success.many.yaml b/test/checks/missingPodDisruptionBudget/success.many.yaml
@@ -2,10 +2,11 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: zookeeper
-  labels:
-    app.kubernetes.io/name: zookeeper
 spec:
   template:
+    metadata:
+      labels:
+        app.kubernetes.io/name: zookeeper
     spec:
       containers:
       - name: zookeeper

diff --git a/test/checks/missingPodDisruptionBudget/success.yaml b/test/checks/missingPodDisruptionBudget/success.yaml
@@ -2,10 +2,12 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: zookeeper
-  labels:
-    app.kubernetes.io/name: zookeeper
 spec:
   template:
+    metadata:
+      labels:
+        app.kubernetes.io/name: zookeeper
+        foo: bar
     spec:
       containers:
       - name: zookeeper