Skip to content

Commit

Permalink
fix network mssg wording
Browse files Browse the repository at this point in the history
  • Loading branch information
JessicaGreben committed Feb 13, 2019
1 parent 7195793 commit 97844d5
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion pkg/validator/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,6 @@ func (cv *ContainerValidation) validateHostPort(conf conf.HostNetworking) {
return
}
}
cv.addSuccess("Host port should not be configured")
cv.addSuccess("Host port is not configured")
}
}
8 changes: 4 additions & 4 deletions pkg/validator/pod.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (pv *PodValidation) hostAlias(conf conf.HostNetworking) {
return
}
}
pv.addSuccess("Host alias should not be configured")
pv.addSuccess("Host alias is not configured")
}
}

Expand All @@ -133,7 +133,7 @@ func (pv *PodValidation) hostIPC(conf conf.HostNetworking) {
pv.addFailure("Host IPC is configured, but it shouldn't be")
return
}
pv.addSuccess("Host IPC should not be configured")
pv.addSuccess("Host IPC is not configured")
}
}

Expand All @@ -143,7 +143,7 @@ func (pv *PodValidation) hostPID(conf conf.HostNetworking) {
pv.addFailure("Host PID is configured, but it shouldn't be")
return
}
pv.addSuccess("Host PID should not be configured")
pv.addSuccess("Host PID is not configured")
}
}

Expand All @@ -153,6 +153,6 @@ func (pv *PodValidation) hostNetwork(conf conf.HostNetworking) {
pv.addFailure("Host network is configured, but it shouldn't be")
return
}
pv.addSuccess("Host network sould not be configured")
pv.addSuccess("Host network is not configured")
}
}
8 changes: 4 additions & 4 deletions pkg/validator/pod_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ func TestValidatePod(t *testing.T) {
}

expectedMssgs := []ResultMessage{
ResultMessage{Message: "Host alias should not be configured", Type: "success"},
ResultMessage{Message: "Host IPC should not be configured", Type: "success"},
ResultMessage{Message: "Host PID should not be configured", Type: "success"},
ResultMessage{Message: "Host network sould not be configured", Type: "success"},
ResultMessage{Message: "Host alias is not configured", Type: "success"},
ResultMessage{Message: "Host IPC is not configured", Type: "success"},
ResultMessage{Message: "Host PID is not configured", Type: "success"},
ResultMessage{Message: "Host network is not configured", Type: "success"},
}

actualRR := ValidatePod(c, &pod.Spec)
Expand Down

0 comments on commit 97844d5

Please sign in to comment.