Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fields to versions. ReplacedIn and ReplacementAPI #59

Merged
merged 21 commits into from
Apr 22, 2020
Merged

Adding fields to versions. ReplacedIn and ReplacementAPI #59

merged 21 commits into from
Apr 22, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Apr 17, 2020 •
edited
Loading

  • Changes the output flags to be -o normal and -o wide in order to accommodate the large number of fields
  • Add replacedIn and replacementAPI as fields to the versions
  • Move list of deprecations to it's own file
  • Add deprecated output to the JSON and YAML

Fixes #54
Fixes #48
Fixes #62
Fixes #52

@sudermanjr sudermanjr force-pushed the sudermanjr/replacedin-and-replacementapi branch from 1191425 to c1e23f9 Compare April 20, 2020 15:28
@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #59 into master will increase coverage by 3.26%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   77.68%   80.95%   +3.26%     
==========================================
  Files           5        5              
  Lines         251      273      +22     
==========================================
+ Hits          195      221      +26     
+ Misses         41       38       -3     
+ Partials       15       14       -1
Impacted Files Coverage Δ
pkg/api/output.go 86.66% <93.84%> (+7.25%) ⬆️
pkg/api/versions.go 100.00% <100.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ae684a...c25cfee. Read the comment docs.

@sudermanjr sudermanjr mentioned this pull request Apr 20, 2020
Closed
@sudermanjr sudermanjr marked this pull request as ready for review April 20, 2020 21:14
@sudermanjr sudermanjr requested a review from lucasreed as a code owner April 20, 2020 21:14
lucasreed
lucasreed approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Awesome improvements all around and even more testing coverage 🎉

Couple inline comments, but nothing that requires a change.

pkg/api/versions.go Show resolved Hide resolved
cmd/root.go Show resolved Hide resolved
pkg/api/output.go Show resolved Hide resolved
pkg/api/versions_test.go Outdated Show resolved Hide resolved
@sudermanjr sudermanjr requested a review from lucasreed April 22, 2020 17:23
lucasreed
lucasreed approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sudermanjr sudermanjr merged commit 9753d9d into master Apr 22, 2020
@sudermanjr sudermanjr deleted the sudermanjr/replacedin-and-replacementapi branch April 22, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasreed lucasreed lucasreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sudermanjr @lucasreed