Fixed a linter error causing lack of compilation in Go 1.19 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng deprecated io/ioutil functions and replacing them with their Go 1.16 counterparts.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a linter error causing build to fail in Go 1.19 by removing deprecated io/ioutil functions and replacing them with their Go 1.16 counterparts.
This PR fixes #438
Checklist
Description
What's the goal of this PR?
To allow compilation using Go 1.19, by replacing deprecated Go functions with their counterparts.
What changes did you make?
I changed "io/ioutil".ReadFile to os.ReadFile and "io/ioutil".ReadAll to os.ReadAll for all occurrences.
What alternative solution should we consider, if any?
If backwards compatibility with Go versions prior to 1.16 is important for this project, a solution which vendors the dependency with version-specific calls should be favoured.