Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow hiding headers in output #417

Merged
merged 4 commits into from
Jan 5, 2023
Merged

feat: allow hiding headers in output #417

merged 4 commits into from
Jan 5, 2023

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Nov 23, 2022 •
edited
Loading

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Allow hiding headers in output.

What changes did you make?

Add a --no-headers flag that hide headers in tab, markdown and csv outputs.

What alternative solution should we consider, if any?

pluto [snip] -ocsv | grep -v 'KIND,[snip]'

@aslafy-z aslafy-z force-pushed the feat/hide-headers branch 2 times, most recently from 3dde60b to 458eadf Compare November 23, 2022 11:50
@aslafy-z aslafy-z changed the title fix: preserve ordering of custom collumns feat: allow hiding headers in output Nov 23, 2022
@aslafy-z aslafy-z force-pushed the feat/hide-headers branch 5 times, most recently from 91378de to c2deb25 Compare November 23, 2022 12:33
sudermanjr
sudermanjr requested changes Dec 5, 2022
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Some small nits inline about consistency, but otherwise functionality seems to work as intended.

docs/advanced.md Outdated Show resolved Hide resolved
docs/advanced.md Outdated Show resolved Hide resolved
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Dec 5, 2022

@sudermanjr I just applied the changes.

@aslafy-z aslafy-z requested a review from sudermanjr January 4, 2023 03:13
aslafy-z and others added 2 commits January 4, 2023 04:13
@aslafy-z
feat: option to hide headers
1300fa8
@aslafy-z @sudermanjr
Apply suggestions from code review
6a00c45 
Co-authored-by: Andrew Suderman <andy@suderman.dev>
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Jan 4, 2023

@transient1 @sudermanjr can one of you trigger the tests please?

sudermanjr
sudermanjr approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sudermanjr sudermanjr merged commit 5c9e199 into FairwindsOps:master Jan 5, 2023
@aslafy-z aslafy-z deleted the feat/hide-headers branch January 5, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudermanjr sudermanjr sudermanjr approved these changes

@transient1 transient1 Awaiting requested review from transient1 transient1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aslafy-z @sudermanjr