Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding brew tap to goreleaser. Update README with exit codes and homebrew. #36

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Adding brew tap to goreleaser. Update README with exit codes and homebrew. #36

merged 3 commits into from
Apr 14, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Apr 14, 2020 •
edited
Loading

Fixes #35
Fixes #37

@sudermanjr sudermanjr requested a review from lucasreed as a code owner April 14, 2020 15:21
lucasreed
lucasreed approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 14, 2020 •
edited
Loading

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files           5        5           
  Lines         229      229           
=======================================
  Hits          175      175           
  Misses         39       39           
  Partials       15       15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c89c92...dc34487. Read the comment docs.

@sudermanjr sudermanjr changed the title Adding brew tap to goreleaser Adding brew tap to goreleaser. Update README with exit codes and homebrew. Apr 14, 2020
@sudermanjr sudermanjr requested a review from rbren April 14, 2020 16:06
@sudermanjr sudermanjr merged commit ca19499 into master Apr 14, 2020
@sudermanjr sudermanjr deleted the sudermanjr/brew-release branch April 14, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@lucasreed lucasreed lucasreed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document exit-code option for CI/CD Brew release for quick macos adoption.
3 participants
@sudermanjr @lucasreed @rbren