Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo to README #32

Merged
merged 9 commits into from
Apr 10, 2020
Merged

Add logo to README #32

merged 9 commits into from
Apr 10, 2020

Conversation

rbren
Copy link
Contributor

@rbren rbren commented Apr 9, 2020

How it looks

I also made a couple phrasing changes to improve scannability - happy to revert as y'all see fit.

The tagline is probably too snarky, but I left it in there for a laugh. Will remove the strike before merging

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #32 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #32   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files           5        5           
  Lines         229      229           
=======================================
  Hits          175      175           
  Misses         39       39           
  Partials       15       15           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2262aee...2182531. Read the comment docs.

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I like the snarky tagline, but trust your judgment! LGTM

@rbren rbren merged commit 0c4af71 into master Apr 10, 2020
@rbren rbren deleted the rb/logo branch April 10, 2020 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants