Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e testing for helm 2. Remove ref to --show-non-deprecated. Add helm2 to readme. #29

Merged
merged 2 commits into from
Apr 3, 2020

Conversation

sudermanjr
Copy link
Member

Fixes #28 - Remove ref to --show-non-deprecated.

@sudermanjr sudermanjr requested a review from lucasreed as a code owner April 2, 2020 21:46
@codecov
Copy link

codecov bot commented Apr 2, 2020

Codecov Report

Merging #29 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files           5        5           
  Lines         222      222           
=======================================
  Hits          168      168           
  Misses         39       39           
  Partials       15       15
Impacted Files Coverage Δ
pkg/api/output.go 74.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8868796...ccec0da. Read the comment docs.

@sudermanjr sudermanjr mentioned this pull request Apr 2, 2020
1 task
Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one nit with wording in the README. Not a blocker.

README.md Outdated Show resolved Hide resolved
@sudermanjr sudermanjr merged commit a282399 into master Apr 3, 2020
@sudermanjr sudermanjr deleted the sudermanjr/e2e-helm2 branch April 3, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message shows wrong flag
2 participants