Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding basic functional testing. #24

Merged
merged 8 commits into from
Mar 27, 2020
Merged

Adding basic functional testing. #24

merged 8 commits into from
Mar 27, 2020

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Mar 27, 2020

This adds a few test cases, including detect-helm in a cluster.

Fixes #23

I also did some work on the README badges to make them more consistent.

Screenshot of new Readme header:
Screen Shot 2020-03-27 at 5 00 15 PM

@sudermanjr sudermanjr requested a review from lucasreed as a code owner March 27, 2020 22:40
@codecov
Copy link

codecov bot commented Mar 27, 2020

Codecov Report

Merging #24 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   71.73%   71.73%           
=======================================
  Files           5        5           
  Lines         283      283           
=======================================
  Hits          203      203           
  Misses         60       60           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81e11a8...0e06afc. Read the comment docs.

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow. 🔥

@lucasreed lucasreed merged commit 97d3527 into master Mar 27, 2020
@lucasreed lucasreed deleted the sudermanjr/e2e branch March 27, 2020 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do functional testing with Kind
2 participants