Adding helm tests + goreportcard fixes #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasreed
commented
Mar 27, 2020
- made Kube struct private to the helm pkg
- added helm tests for things that don't interact with kube
- I might be able to improve coverage moving some things around later
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
===========================================
+ Coverage 52.36% 64.55% +12.19%
===========================================
Files 5 5
Lines 254 268 +14
===========================================
+ Hits 133 173 +40
+ Misses 111 77 -34
- Partials 10 18 +8
Continue to review full report at Codecov.
|
sudermanjr
reviewed
Mar 27, 2020
| @@ -134,14 +141,19 @@ func (h *Helm) setCurrentReleases(allReleases []*Release) error { | |||
| // This function is ripped straight out of the helm 3 codebase with slight modification | |||
| // https://github.com/helm/helm/blob/193850a9e2c509acf1a499d98e8d23c12c134f11/pkg/storage/driver/util.go#L56-L84 | |||
| func decodeReleaseSecret(data string) (*Release, error) { | |||
| if len(data) < 1 { | |||
There was a problem hiding this comment.
I love it when testing helps us catch stuff like this.
sudermanjr
approved these changes
Mar 27, 2020
|
Thanks!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.