Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NewHelmWithKubeClient #133

Merged

Conversation

ishankhare07
Copy link
Contributor

allows to programmatically creating helm client
for the given kube config

Fixes: #132

Signed-off-by: Ishan Khare ishankhare07@gmail.com

allows to programatically creating helm client
for the given kube config

Signed-off-by: Ishan Khare <ishankhare07@gmail.com>
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #133 into master will decrease coverage by 1.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   81.81%   80.39%   -1.43%     
==========================================
  Files           7        7              
  Lines         451      459       +8     
==========================================
  Hits          369      369              
- Misses         55       63       +8     
  Partials       27       27              
Impacted Files Coverage Δ
pkg/helm/helm.go 56.25% <0.00%> (-5.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f7c80...20fe1f8. Read the comment docs.

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucasreed lucasreed merged commit 0ed2745 into FairwindsOps:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing in a kubeclient or config when creating NewHelm
2 participants