Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error if there are no apiVersions found #118

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

sudermanjr
Copy link
Member

Fixes #117

This changes a bit more behavior than I would like, but I think it's fine. Look carefully

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #118 into master will decrease coverage by 3.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
- Coverage   84.17%   81.12%   -3.06%     
==========================================
  Files           7        7              
  Lines         512      445      -67     
==========================================
- Hits          431      361      -70     
  Misses         55       55              
- Partials       26       29       +3     
Impacted Files Coverage Δ
pkg/api/versions.go 89.67% <100.00%> (-1.29%) ⬇️
pkg/finder/finder.go 75.00% <0.00%> (-10.97%) ⬇️
pkg/helm/helm.go 62.79% <0.00%> (-5.58%) ⬇️
pkg/api/output.go 88.37% <0.00%> (-1.22%) ⬇️
pkg/helm/kube.go 0.00% <0.00%> (ø)
pkg/api/columns.go 100.00% <0.00%> (ø)
pkg/api/helpers.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83da97f...15f4a6b. Read the comment docs.

@sudermanjr sudermanjr marked this pull request as ready for review September 25, 2020 17:24
@sudermanjr
Copy link
Member Author

I approve of @lucasreed 's changes to my changes

@sudermanjr sudermanjr merged commit 74959ec into master Sep 25, 2020
@sudermanjr sudermanjr deleted the sudermanjr/no-error-on-zero-results branch September 25, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty manifest should be passed
2 participants